This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Enable libstdc++ numeric conversions on Cygwin
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: Jennifer Yao <jenny dot hyphen dot fa at gmail dot com>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Andreas Tobler <andreast-list at fgznet dot ch>
- Date: Sun, 15 Nov 2015 17:25:05 +0100
- Subject: Re: [PATCH] Enable libstdc++ numeric conversions on Cygwin
- Authentication-results: sourceware.org; auth=none
- References: <CAPQfdh=Kshcq=Eg5EV9rpho=Q0USrGgODPoLzSLuvK+5D6LGeA at mail dot gmail dot com> <CAPQfdhmMGJeb-tq29jTheoo5jUaeiFzcycWFTrpShRE-kPftGw at mail dot gmail dot com> <CAPQfdh=uOjLzi60Dnd0Dd1ycJUDqMWQBCv1aRAGBP97DSUS3+Q at mail dot gmail dot com> <20151112114049 dot GY2937 at redhat dot com> <20151112133947 dot GA2937 at redhat dot com> <20151113145219 dot GQ2937 at redhat dot com> <CAKdteObx+-EmP+zeF8vp3diy7Y_52eR+=9H4=kNowJAa=ZnoCA at mail dot gmail dot com> <20151114163223 dot GE2937 at redhat dot com> <CAKdteOZfHT5EDt6U7i3ym6HNXXkgzJMWwm42BUGhjpbNqXhpog at mail dot gmail dot com> <20151115111428 dot GG2937 at redhat dot com>
On 15 November 2015 at 12:14, Jonathan Wakely <jwakely@redhat.com> wrote:
> On 15/11/15 09:58 +0100, Christophe Lyon wrote:
>>
>> Ha, and my newlib copy is not very recent, it's from Oct 30th 2013:
>> maybe it's too old?
>
>
> The autoconf checks should handle old versions as well as new.
>
> The problem is I didn't change a defined(_GLIBCXX_USE_C99_WCHAR) to
> just test its value, rather than whether it's defined.
>
> As I added to include/bits/c++config on Friday:
>
> // N.B. these _GLIBCXX_USE_C99_XXX macros are defined unconditionally
> // so they should be tested with #if not with #ifdef.
>
> Fixed with this patch, committed to trunk.
>
Thanks, this does fix the build of aarch64*-none-elf.
The arm*-none-eabi ones are still failing, but for another reason now.
Lots of things have been committed in the past few days :-)