This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.

From: Jonathan Wakely <jwakely at redhat dot com>
To: Gerald Pfeifer <gerald at pfeifer dot com>
Cc: "Dominique d'Humières" <dominiq at lps dot ens dot fr>, ville dot voutilainen at gmail dot com, gcc-patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
Date: Thu, 12 Nov 2015 16:13:04 +0000
Subject: Re: [v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.
Authentication-results: sourceware.org; auth=none
References: <50707C06-EB02-4B6B-A84C-40204207C07B at lps dot ens dot fr> <20151111173006 dot GP2937 at redhat dot com> <alpine dot LSU dot 2 dot 20 dot 1511121522300 dot 2548 at anthias> <20151112143608 dot GC2937 at redhat dot com>

On 12/11/15 14:36 +0000, Jonathan Wakely wrote:

On 12/11/15 15:23 +0100, Gerald Pfeifer wrote:

On Wed, 11 Nov 2015, Jonathan Wakely wrote:

Fixed by this patch.


Thanks, Jonathan!  Unfortunately bootstrap is still broken
(on i386-unknown-freebsd11.0 at least):


Different issue.

In file included from/scratch/tmp/gerald/gcc-HEAD/libstdc++-v3/src/c++11/thread.cc:27:0:

/scratch/tmp/gerald/OBJ-1112-1414/i386-unknown-freebsd10.2/libstdc++-v3/include/
thread: In function âvoid std::this_thread::sleep_for(const std::chrono::duration<_Rep1, _Period1>&)â:
/scratch/tmp/gerald/OBJ-1112-1414/i386-unknown-freebsd10.2/libstdc++-v3/include/
thread:300:44: error: âerrnoâ was not declared in this scope
while (::nanosleep(&__ts, &__ts) == -1 && errno == EINTR)
                                         ^
/scratch/tmp/gerald/OBJ-1112-1414/i386-unknown-freebsd10.2/libstdc++-v3/include/
thread:300:53: error: âEINTRâ was not declared in this scope
while (::nanosleep(&__ts, &__ts) == -1 && errno == EINTR)


Does adding #include <errno.h> to libstdc++-v3/include/std/thread
solve it?


Committed to trunk.

commit ede84363f2a4374b0d16ffda19fbcffdc44221c3
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Nov 12 15:21:24 2015 +0000

    	* include/std/thread: Include <cerrno> for EINTR.

diff --git a/libstdc++-v3/include/std/thread b/libstdc++-v3/include/std/thread
index 5940e6e..8c01feb 100644
--- a/libstdc++-v3/include/std/thread
+++ b/libstdc++-v3/include/std/thread
@@ -38,6 +38,7 @@
 #include <chrono>
 #include <functional>
 #include <memory>
+#include <cerrno>
 #include <bits/functexcept.h>
 #include <bits/functional_hash.h>
 #include <bits/gthr.h>

Follow-Ups:
- Re: [v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.
  - From: Gerald Pfeifer

References:
- Re: [v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.
  - From: Dominique d'HumiÃres
- Re: [v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.
  - From: Jonathan Wakely
- Re: [v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.
  - From: Gerald Pfeifer
- Re: [v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]