Re: [PATCH] Add configure flag for operator new (std::nothrow)

[Paolo Carlini <paolo dot carlini at oracle dot com>]

Hi,

On 11/03/2015 01:35 PM, Aurelio Remonda wrote:
> diff --git a/ChangeLog b/ChangeLog
> index 5b16ca2..a1cd0d3 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,12 @@
> +2015-10-30  Aurelio Remonda  <aurelio.remonda@tallertechnologies.com>
> +
> +	* libstdc++-v3/acinclude.m4: add enable_new_opnt_no_allocation_retry
> +	flag definition.
> +	* libstdc++-v3/configure.ac: add option flag
> +	GLIBCXX_ENABLE_NEW_OPNT_NO_ALLOCATION_RETRY
> +	* libstdc++-v3/libsupc++/new_opnt.cc use the defined macro
> +	* libstdc++-v3/doc/xml/manual/configure.xml
> +
Three minor comments. First, ChangeLog entries aren't normally submitted 
as part of the patch. Second, since the ChangeLog is under libstdc++-v3, 
the ChangeLog entries should not have libstdc++-v3 in the paths (eg, 
just * acinclude.m4: ...). Finally, since you are touching acinclude.m4 
you should normally run autoreconf, mention in the ChangeLog the changed 
regenerated files and eventually commit those changes too (like the 
ChangeLog entries, those aren't normally part of the posted patch) About 
the three issues, you have plenty of examples in the mailing list.

Otherwise, about the substance of the patch, I think we want to wait for 
Jonathan to be back.

Paolo.