This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [GSoC] Patches for shared_ptr array and polymorphic_allocator

From: Fan You <youfan dot noey at gmail dot com>
To: Jonathan Wakely <jwakely at redhat dot com>, Tim Shen <timshen at google dot com>
Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>
Date: Wed, 5 Aug 2015 16:19:31 -0400
Subject: Re: [GSoC] Patches for shared_ptr array and polymorphic_allocator
Authentication-results: sourceware.org; auth=none
References: <CALvpekFHJ1k2pcQdJxFCbppPf3N6HTGjR-JQyNZi0_oLZJEC5Q at mail dot gmail dot com> <CAG4ZjNmWxZSdoWpk2RtOJpPy1XpUtFbJuny1YxG065SnraKvWQ at mail dot gmail dot com> <CALvpekG=Muiw8a9h1OzHGD7Yn6iytmMyTwYPQs1mX_ZYTjkgTQ at mail dot gmail dot com> <CAG4ZjNnVKpxWeV+JDoBtK7=fZ5duy04aKcSLrUQSTQF=87=4FQ at mail dot gmail dot com> <20150720095050 dot GM21787 at redhat dot com> <CALvpekG0XcKSzAvgv+ZW68W8+oTX3Va20UpuLRJnoF17_FQAwA at mail dot gmail dot com> <20150728115727 dot GK10878 at redhat dot com> <CALvpekEDQnkED5OaMm6Gd=1kgEuBMf+ZMvOep1tKsJXzr5t6pA at mail dot gmail dot com> <CAG4ZjN=dBBMyxVLXqH6Yp__+oiYaRmDah3_yji9b9jQzY1cZ3w at mail dot gmail dot com> <20150804090208 dot GT13355 at redhat dot com>

Sorry, it's a mistake. Fixed, patch updated.

According to n3525, few modification also need to be made on
std::function, I looked into the code of std/functional and I did see
some place marked as "// TODO: needs allocator_arg_t". Can I directly
make changes here?

Jonathan Wakely <jwakely@redhat.com>ä2015å8æ4æåä äå5:02åéï
>
> On 31/07/15 17:51 -0700, Tim Shen wrote:
> >+      bool _M_supported (size_t __x)
> >+      { return ((__x != 0) && (__x != 0) && !(__x & (__x - 1))); }
> >
> >Documentation? Also make it static.
>
> Why does it test the first condition twice?
>
-- 
Regards,

Fan

Attachment: a
Description: Binary data

Follow-Ups:
- Re: [GSoC] Patches for shared_ptr array and polymorphic_allocator
  - From: Jonathan Wakely

References:
- Re: [GSoC] Patches for shared_ptr array and polymorphic_allocator
  - From: Tim Shen
- Re: [GSoC] Patches for shared_ptr array and polymorphic_allocator
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]