This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3 PATCH] Implement N4089 and N4387
- From: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- To: libstdc++ at gcc dot gnu dot org, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 19 Jul 2015 20:13:08 +0300
- Subject: Re: [v3 PATCH] Implement N4089 and N4387
- Authentication-results: sourceware.org; auth=none
- References: <CAFk2RUZtfiKHsz49_JLB6t5YW+X0qxQkCib85XrXAw2ANU5puA at mail dot gmail dot com>
On 19 July 2015 at 19:56, Ville Voutilainen <ville.voutilainen@gmail.com> wrote:
> Tested on Linux-PPC64.
>
> 2015-07-19 Ville Voutilainen <ville.voutilainen@gmail.com>
> Implement N4089 Safe conversions in unique_ptr<T[]> (LWG 2118)
> and N4387 LWG 2228: Missing SFINAE rule in unique_ptr
> templated assignment
> * include/bits/unique_ptr.h
> (__remove_cv, __is_derived_Tp): Remove.
> (default_delete::default_delete(const default_delete<_Up[]>)):
> Constrain with array convertibility.
> (default_delete::operator(_Up*)): Turn into a template,
> constrain with array convertibility.
> (__safe_conversion_up): New, single object version.
> (unique_ptr(unique_ptr<_Up, _Ep>&& __u)): Constrain with array
> convertibility.
> (unique_ptr::operator=(unique_ptr<_Up, _Ep>&& __u)): Likewise, and add
> is_assignable as a constraint.
> (__safe_conversion_up): Array version, renamed from __safe_conversion,
> updated to implement N4089.
> (__safe_conversion_raw): New.
> (unique_ptr(_Up __p)): Turn into a template, constrain with array
> convertibility.
> (unique_ptr(_Up __p,
> typename conditional<is_reference<deleter_type>::value,
> deleter_type, const deleter_type&>::type __d)): Likewise.
> (unique_ptr(_Up __p, typename
> remove_reference<deleter_type>::type&& __d)): Likewise.
> (unique_ptr(unique_ptr<_Up, _Ep>&& __u)): Likewise.
> (operator=(unique_ptr<_Up, _Ep>&& __u)): Likewise, and add
> is_assignable as a constraint (array version).
> (reset(_Up __p)): Turn into a template, constrain with array
> convertibility.
> (reset(nullptr_t p)): New.
> * testsuite/20_util/default_delete/48631_neg.cc: Adjust.
> * testsuite/20_util/unique_ptr/assign/48635.cc: Likewise.
> * testsuite/20_util/unique_ptr/assign/48635_neg.cc: Likewise.
> * testsuite/20_util/unique_ptr/assign/cv_qual.cc: Likewise.
> * testsuite/20_util/unique_ptr/cons/cv_qual.cc: Likewise.
> * testsuite/20_util/unique_ptr/dr2228.cc: New.
> * testsuite/20_util/unique_ptr/modifiers/cv_qual.cc: Adjust.
Minor changelog fix, the single-pointer functions aren't constrained with
array compatibility, but with deleter compatibility.
2015-07-19 Ville Voutilainen <ville.voutilainen@gmail.com>
Implement N4089 Safe conversions in unique_ptr<T[]> (LWG 2118)
and N4387 LWG 2228: Missing SFINAE rule in unique_ptr
templated assignment
* include/bits/unique_ptr.h
(__remove_cv, __is_derived_Tp): Remove.
(default_delete::default_delete(const default_delete<_Up[]>)):
Constrain with array convertibility.
(default_delete::operator(_Up*)): Turn into a template,
constrain with array convertibility.
(__safe_conversion_up): New, single object version.
(unique_ptr(unique_ptr<_Up, _Ep>&& __u)): Constrain with deleter
convertibility.
(unique_ptr::operator=(unique_ptr<_Up, _Ep>&& __u)): Likewise, and add
is_assignable as a constraint.
(__safe_conversion_up): Array version, renamed from __safe_conversion,
updated to implement N4089.
(__safe_conversion_raw): New.
(unique_ptr(_Up __p)): Turn into a template, constrain with array
convertibility.
(unique_ptr(_Up __p,
typename conditional<is_reference<deleter_type>::value,
deleter_type, const deleter_type&>::type __d)): Likewise.
(unique_ptr(_Up __p, typename
remove_reference<deleter_type>::type&& __d)): Likewise.
(unique_ptr(unique_ptr<_Up, _Ep>&& __u)): Likewise.
(operator=(unique_ptr<_Up, _Ep>&& __u)): Likewise, and add
is_assignable as a constraint (array version).
(reset(_Up __p)): Turn into a template, constrain with array
convertibility.
(reset(nullptr_t p)): New.
* testsuite/20_util/default_delete/48631_neg.cc: Adjust.
* testsuite/20_util/unique_ptr/assign/48635.cc: Likewise.
* testsuite/20_util/unique_ptr/assign/48635_neg.cc: Likewise.
* testsuite/20_util/unique_ptr/assign/cv_qual.cc: Likewise.
* testsuite/20_util/unique_ptr/cons/cv_qual.cc: Likewise.
* testsuite/20_util/unique_ptr/dr2228.cc: New.
* testsuite/20_util/unique_ptr/modifiers/cv_qual.cc: Adjust.