This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] Fix two libstdc++ test failures with -std=gnu++14
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Tue, 16 Jun 2015 21:45:25 +0100
- Subject: Re: [patch] Fix two libstdc++ test failures with -std=gnu++14
- Authentication-results: sourceware.org; auth=none
- References: <20150611232228 dot GN12728 at redhat dot com> <558084A4 dot 1060206 at gmail dot com>
On 16/06/15 22:18 +0200, François Dumont wrote:
On 12/06/2015 01:22, Jonathan Wakely wrote:
This fixes two test failures when the default compiler mode is
-std=gnu++14
FAIL: 25_algorithms/headers/algorithm/synopsis.cc (test for excess
errors)
FAIL: ext/profile/mutex_extensions_neg.cc (test for excess errors)
I don't really like the change to the synopsis.cc test, but I don't
think reproducing the SFINAE constraints in the test is ideal either.
The mutex_extensions_neg.cc test works now, but I think we're missing
specializations of __is_tuple_like_impl for __gnu_debug::array and
__gnu_profile::array.
Tested powerpc64le-linux, committed to trunk.
This patch introduced a regression in
20_util/tuple/creation_functions/tuple_cat.cc in debug mode.
Yes, I noticed this today while testing some changes to <debug/list>,
but hadn't had time to do anything about it, so thanks for taking care
of it.
Attached is a proposal to fix it properly. I am using <utility> as a
pivot header between <tuple> and <array>. This way <tuple> do not need
to include <array> anymore.
I think that's a good improvement.
It also adds missing version namespace macro in debug and profile headers.
Not tested yet as I would like to know first if it ok to do it this way.
Looks good to me.