This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] [libstdc++] Add uniform container erasure.
- From: Daniel Krügler <daniel dot kruegler at gmail dot com>
- To: Ed Smith-Rowland <3dw4rd at verizon dot net>
- Cc: Jonathan Wakely <jwakely at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 30 Apr 2015 20:01:02 +0200
- Subject: Re: [PATCH] [libstdc++] Add uniform container erasure.
- Authentication-results: sourceware.org; auth=none
- References: <55421311 dot 90905 at verizon dot net> <20150430123911 dot GS3618 at redhat dot com> <55423FD1 dot 3090301 at verizon dot net>
2015-04-30 16:44 GMT+02:00 Ed Smith-Rowland <3dw4rd@verizon.net>:
>
>> And make_array, which isn't in the working paper yet, so I'd prefer to
>> leave that part out for now.
>
> D'oh! Sorry about that.. Removed.
>>
>> The Doxygen @headername command tells users which header they are
>> supposed to include, rather than this one. Since there is no
>> <erase_if> header that's wrong. I'd just omit the @headername.
>
> Done.
>>
>> This file doesn't really seem like a .tcc to me, it isn't providing
>> definitions of templates declared elsewhere (specifically in an
>> erase_if.h header).
>>
>> Maybe we want an experimental/bits/ directory for this sort of thing
>> (which I could also use for the filesystem headers I'm about to
>> commit) but in the meanwhile I think just experimental/erase_if.h is a
>> better name.
>
> Done. (I didn't make experimental/bits - I'll move erase_if.h after you add
> the bits directory).
>>
>> OK for trunk with those changes (remove make_array, rename erase_if.tcc)
>
> Rebuilt, retested and committed as 222630.
> Altered patch attached.
Shouldn't the "one-liner" forwarding function templates be declared as inline?
- Daniel