This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [libstdc++] pdqsort - a faster std::sort
- From: Marc Glisse <marc dot glisse at inria dot fr>
- To: Orson Peters <orsonpeters at gmail dot com>
- Cc: Christopher Jefferson <chris at bubblescope dot net>, libstdc++ at gcc dot gnu dot org
- Date: Thu, 9 Apr 2015 00:51:48 +0200 (CEST)
- Subject: Re: [libstdc++] pdqsort - a faster std::sort
- Authentication-results: sourceware.org; auth=none
- References: <CAJxLxMXy4gqAWfXj_p1tyyUSj4PqFp3ASzdxFtyDk2W1F_PdsQ at mail dot gmail dot com> <20150407135025 dot GF9755 at redhat dot com> <CAJxLxMVEW-+bSFyDs7sWytEMKVrhMpcQxk-9QetWem8ZtSeSxg at mail dot gmail dot com> <CAJxLxMWkj7kKteFh7YWHv5gr+Fge_2VeN6QdJ_TFqW2nUtin=w at mail dot gmail dot com> <CA+jCFLvDjSjPSF+dKDVuKWW-hsSK_LC3c=VwiFEhhx0EOyiqAA at mail dot gmail dot com> <CAJxLxMU_3vV1cozS1MnfSo5NNodW1J_1zZWuimdpCguO1cO-0w at mail dot gmail dot com> <CA+jCFLubcMg1OxspBjpcKjur6Vi6PJ=Ce_oSkA_b7OqcZR1UwQ at mail dot gmail dot com> <CAJxLxMX6CyVGxPgrZvvJ+Y62RN_86CQ8H0gFdUOHZde0UFJ2dA at mail dot gmail dot com> <CA+jCFLvUxRdmw71_H08ruDCf8QFmXcriE+G2_Cam4t5wQP-1gQ at mail dot gmail dot com> <CAJxLxMXfZ-GoTPO9uQ2Y9QyQJ_ep_+Ls4Di5q5A0B849Y32chg at mail dot gmail dot com> <CA+jCFLvtfsq6+0_r-iXAjE6JSBrxkDuaFu6FMguVhCghOdc0bw at mail dot gmail dot com> <CAJxLxMVhpu8rechANs8q+C4yxKA+587VCZsDqz0UiScMJBEXNA at mail dot gmail dot com>
- Reply-to: libstdc++ at gcc dot gnu dot org
On Thu, 9 Apr 2015, Orson Peters wrote:
1. Should iter_swap be used like swap (using std::swap; followed by
unqualified lookup), or should it be fully qualified as
std::iter_swap?
Fully qualified.
2. Is there any particular reason _Iter_comp_iter and co store copies
of the comparator, and not a reference?
Probably not. But if that changes, it should be a separate patch,
submitted in a separate email.
Note that you can search the mailing list for explanations on the strange
functor stuff if you are curious, it is quite recent. Here are some random
links, but the conversation was spread over many more months, the
interesting parts may be in other threads (look for the name "FranÃois
Dumont").
https://gcc.gnu.org/ml/libstdc++/2012-05/msg00006.html
https://gcc.gnu.org/ml/libstdc++/2013-09/msg00004.html
https://gcc.gnu.org/ml/libstdc++/2013-09/msg00150.html
--
Marc Glisse