This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Ping] Port of VTV for Cygwin and MinGW
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Matthias Klose <doko at ubuntu dot com>, Caroline Tice <cmtice at google dot com>, Patrick Wollgast <patrick dot wollgast at rub dot de>, Kai Tietz <ktietz70 at googlemail dot com>, Benjamin De Kosnik <bkoz at gnu dot org>, "jwakely at redhat dot com >> Jonathan Wakely" <jwakely at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 29 Jan 2015 10:34:01 -0800
- Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
- Authentication-results: sourceware.org; auth=none
- References: <CAKOQZ8wCM4+0guCsqzeFZjgUu-Y81NX9RbGhV-i7xz8_OVuMyQ at mail dot gmail dot com> <54B83638 dot 7080509 at rub dot de> <54C8C89C dot 1000104 at rub dot de> <CABtf2+R2kY+tv7Wk+rtnU6s55RbMmSgejqeWn11rqb7PHA-COA at mail dot gmail dot com> <54CA737A dot 5060102 at ubuntu dot com> <54CA767F dot 9040102 at ubuntu dot com> <CAMe9rOohc7imtMstqRBJCnbUsms9DNDgYO=GcYmjao9b0c9Szg at mail dot gmail dot com> <54CA78F1 dot 1020204 at ubuntu dot com> <20150129182641 dot GP1746 at tucnak dot redhat dot com> <CAMe9rOrAGT7pq9v-NfJbfEKmPOk7Jv01yAHdpTfwWbM4cxu6ug at mail dot gmail dot com> <20150129183005 dot GQ1746 at tucnak dot redhat dot com>
On Thu, Jan 29, 2015 at 10:30 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Jan 29, 2015 at 10:28:17AM -0800, H.J. Lu wrote:
>> >> --- acinclude.m4 (revision 220257)
>> >> +++ acinclude.m4 (working copy)
>> >> @@ -2320,8 +2320,6 @@
>> >> AC_MSG_CHECKING([for vtable verify support])
>> >> AC_MSG_RESULT([$enable_vtable_verify])
>> >>
>> >> - AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
>> >> -
>> >> if test $enable_vtable_verify = yes; then
>> >> case ${target_os} in
>> >> cygwin*|mingw32*)
>> >> @@ -2341,6 +2339,8 @@
>> >> VTV_CXXLINKFLAGS=
>> >> fi
>> >>
>> >> + AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
>> >> +
>> >
>>
>> Or we can just do
>>
>> AM_CONDITIONAL(VTV_CYGMIN, test x$vtv_cygmin = xyes)
>
> Or that, but that is not what you've checked in.
> Some shells will be upset about test $vtv_cygmin = yes when
> $vtv_cygmin expands to empty string.
>
Yes, I got
checking for vtable verify support... no
/export/gnu/import/git/sources/gcc/libstdc++-v3/configure: line 17481:
test: =: unary operator expected
At least it doesn't stop bootstrap. Either fix is fine with me.
--
H.J.