This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Ping] Port of VTV for Cygwin and MinGW
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: Matthias Klose <doko at ubuntu dot com>, Caroline Tice <cmtice at google dot com>, Patrick Wollgast <patrick dot wollgast at rub dot de>, Kai Tietz <ktietz70 at googlemail dot com>, Benjamin De Kosnik <bkoz at gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 29 Jan 2015 10:16:31 -0800
- Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
- Authentication-results: sourceware.org; auth=none
- References: <CAKOQZ8wVtj_+e=Jax6mKc+Uq3FOeQzTZubejk-TDJBFhPhxABQ at mail dot gmail dot com> <54B6D159 dot 4000002 at rub dot de> <CAKOQZ8w9_5OJEfnWJ-rgBgVzOzQcEj984MQcp=R1w=0JLUU8mw at mail dot gmail dot com> <54B77230 dot 6070704 at rub dot de> <CAKOQZ8wCM4+0guCsqzeFZjgUu-Y81NX9RbGhV-i7xz8_OVuMyQ at mail dot gmail dot com> <54B83638 dot 7080509 at rub dot de> <54C8C89C dot 1000104 at rub dot de> <CABtf2+R2kY+tv7Wk+rtnU6s55RbMmSgejqeWn11rqb7PHA-COA at mail dot gmail dot com> <54CA737A dot 5060102 at ubuntu dot com> <54CA767F dot 9040102 at ubuntu dot com> <20150129181105 dot GK3360 at redhat dot com> <CAMe9rOp86qCLqNTSHJx+ZDTf=DpQJB8uCKAv_qEoeNYo7HOtFA at mail dot gmail dot com>
On Thu, Jan 29, 2015 at 10:13 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Jan 29, 2015 at 10:11 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
>> On 29/01/15 19:05 +0100, Matthias Klose wrote:
>>>
>>> that fixes the build failure. ok to commit?
>>>
>>> 2015-01-29 Matthias Klose <doko@ubuntu.com>
>>>
>>> * acinclude.m4 (GLIBCXX_ENABLE_VTABLE_VERIFY): Define VTV_CYGMIN
>>> unconditionally.
>>> * configure: Regenerate.
>>
>>
>> OK, thanks.
>>
>
> It is NOT OK.
>
This patch checks vtv_cygmin after it is defined. I will
check it in as an obvious fix after testing.
--
H.J.
---
diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
index 59df22d..02ca3f3 100644
--- a/libstdc++-v3/acinclude.m4
+++ b/libstdc++-v3/acinclude.m4
@@ -2331,7 +2331,6 @@ AC_DEFUN([GLIBCXX_ENABLE_VTABLE_VERIFY], [
vtv_cygmin="no"
;;
esac
- AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
VTV_PCH_CXXFLAGS="-fvtable-verify=std"
VTV_CXXLINKFLAGS="-L${toplevel_builddir}/libvtv/.libs -Wl,--rpath
-Wl,${toplevel_builddir}/libvtv/.libs"
else
@@ -2340,6 +2339,8 @@ AC_DEFUN([GLIBCXX_ENABLE_VTABLE_VERIFY], [
VTV_CXXLINKFLAGS=
fi
+ AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
+
AC_SUBST(VTV_CXXFLAGS)
AC_SUBST(VTV_PCH_CXXFLAGS)
AC_SUBST(VTV_CXXLINKFLAGS)