This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH, RFC] PR c++/63959, continued


On 20 January 2015 at 15:06, Jason Merrill <jason@redhat.com> wrote:
> On 01/19/2015 06:06 PM, Ville Voutilainen wrote:
>>
>> +      return (trivial_type_p (type1)
>> +             || (scalarish_type_p (type1) && CP_TYPE_VOLATILE_P (type1))
>> +             || type_code1 == REFERENCE_TYPE
>>               || (CLASS_TYPE_P (type1)
>>                   && TYPE_HAS_TRIVIAL_DESTRUCTOR (type1)));
>
>
> I think we can drop the trivial_type_p check now, it's redundant.


Well, we can do even better, just check for scalarish_type instead of
trivial || scalarish && volatile. ;) Patch attached, changelog as before.
I re-ran the tests that previously were failing in the first versions of the
patch, didn't run the full suite again, as I unfortunately need to run. :)

Attachment: pr63959_4.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]