Re: [Patch, ARM, ping1] Fix PR target/56846

[Richard Biener <rguenther at suse dot de>]

On Thu, 27 Nov 2014, Ramana Radhakrishnan wrote:

> 
> 
> On 27/11/14 09:34, Richard Biener wrote:
> > On Thu, 27 Nov 2014, Thomas Preud'homme wrote:
> > 
> > > Thanks. Ccing release manager for their opinion.
> > 
> > It doesn't look ARM specific and frankly I have not too much expertise
> > in this area.  The patch has been on trunk for more than two months
> > though so I guess it is ok to backport.
> > 
> 
> It is ARM specific because the whole thing sits in a #ifdef
> __ARM_EABI_UNWINDER__ in eh_personality.cc.

Ah, too little patch context then.

Richard.

> regards
> Ramana
> 
> > Richard.
> > 
> > > Best regards,
> > > 
> > > Thomas
> > > 
> > > > -----Original Message-----
> > > > From: Jonathan Wakely [mailto:jwakely@redhat.com]
> > > > Sent: Wednesday, November 26, 2014 5:33 PM
> > > > To: Thomas Preud'homme
> > > > Cc: Tony Wang; gcc-patches@gcc.gnu.org; dan@debian.org; aph-
> > > > gcc@littlepinkcloud.com; Richard Earnshaw; Ramana Radhakrishnan;
> > > > libstdc++@gcc.gnu.org
> > > > Subject: Re: [Patch, ARM, ping1] Fix PR target/56846
> > > > 
> > > > On 26/11/14 17:23 -0000, Thomas Preud'homme wrote:
> > > > > Ping?
> > > > 
> > > > I'm OK with backporting it if a release manager approves it.
> > > > 
> > > > 
> > > > > > -----Original Message-----
> > > > > > From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
> > > > > > owner@gcc.gnu.org] On Behalf Of Thomas Preud'homme
> > > > > > Sent: Wednesday, November 19, 2014 6:00 PM
> > > > > > To: Tony Wang; gcc-patches@gcc.gnu.org; dan@debian.org; aph-
> > > > > > gcc@littlepinkcloud.com; Richard Earnshaw; Ramana Radhakrishnan;
> > > > > > libstdc++@gcc.gnu.org
> > > > > > Subject: RE: [Patch ARM] Fix PR target/56846
> > > > > > 
> > > > > > > From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
> > > > > > > owner@gcc.gnu.org] On Behalf Of Tony Wang
> > > > > > > 
> > > > > > 
> > > > > > > 
> > > > > > > Hi all,
> > > > > > > 
> > > > > > > The bug is reported at
> > > > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56846, and itâs about
> > > > the
> > > > > > > problem that
> > > > > > > when exception handler is involved in the function, then
> > > > > > > _Unwind_Backtrace function will run into deadloop on
> > > > > > > arm target.
> > > > > > 
> > > > > > The patch (in r215101) can be backported without any change on 4.8
> > > > and
> > > > > > 4.9 branches. I checked in QEMU with and without the patch on both
> > > > > > branches and it indeed solves the problem.
> > > > > > 
> > > > > > Testsuite run without regression when compiled with arm-none-eabi
> > > > > > cross compiler and executed on QEMU emulating Cortex-M3.
> > > > > > 
> > > > > > I also bootstrapped gcc on x86_64-linux-gnu and run the testsuite
> > > > > > without
> > > > > > regressions.
> > > > > > 
> > > > > > Is it ok for backport?
> > > > > > 
> > > > > > Best regards,
> > > > > > 
> > > > > > Thomas
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > 
> > > 
> > > 
> > > 
> > > 
> > 
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284
(AG Nuernberg)
Maxfeldstrasse 5, 90409 Nuernberg, Germany