This is the mail archive of the
mailing list for the libstdc++ project.
Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 10 Nov 2014 22:20:00 +0000
- Subject: Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range
- Authentication-results: sourceware.org; auth=none
- References: <5441800A dot 1040609 at gmail dot com> <546124F8 dot 4050003 at gmail dot com> <20141110214511 dot GF5191 at redhat dot com> <546138B1 dot 7000304 at gmail dot com>
On 10/11/14 23:14 +0100, François Dumont wrote:
I introduced the random tests after Christopher Jefferson request
to have more intensive tests on those algos. Is it the whole stuff of
tests using random numbers that you don't like or just the usage of
The use of random number in general.
If second is this new version using the usual random_device
I used so far better ?
That would be much worse because failures would not be reproducible!
If it is the whole usage of random numbers that you don't like I will
simply get rid of the new tests files.
Did the new tests fail before your fix to stl_algo.h?
If yes, you could extract the values generated in the case that fails
and add a test using those values (this is what I should have done for
the leaking set tests)
If no, they aren't really testing anything useful.