This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] LWG 2019 - std::isblank<C>(C, const std::locale&)

From: Jonathan Wakely <jwakely at redhat dot com>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
Cc: Tim Shen <timshen at google dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
Date: Tue, 4 Nov 2014 02:52:15 +0000
Subject: Re: [patch] LWG 2019 - std::isblank<C>(C, const std::locale&)
Authentication-results: sourceware.org; auth=none
References: <20141017094122 dot GR4197 at redhat dot com> <20141020123459 dot GD3033 at redhat dot com> <CAG4ZjN=26F-RynqfrYeMf6HbB2amgbk_Y3cN7SnHxJL-1YE+7A at mail dot gmail dot com> <CAH6eHdQR+HJxnvCrsemSQfxL5pr1n+1NyOMZ=5FOjKSdi5u1zA at mail dot gmail dot com> <20141021122619 dot GJ3033 at redhat dot com>

On 21/10/14 13:26 +0100, Jonathan Wakely wrote:

On 20/10/14 23:08 +0100, Jonathan Wakely wrote:

On 20 October 2014 18:40, Tim Shen <timshen@google.com> wrote:

On Mon, Oct 20, 2014 at 5:34 AM, Jonathan Wakely <jwakely@redhat.com> wrote:

Committed to trunk.


Yay, I think it's the time to remove regex_traits::_RegexMask?


Yes, I wanted to get isblank in first, and see how many targets I
broke, then revisit regex.


I don't think we can remove _RegexMask entirely, as we still need
special handling for the "w" class, so maybe something like the
attached.

Alternatively we could replace _M_extended with bool _M_under and not
need to do any bitwise operations like _M_extended & _S_valid_mask.


I've committed the attached.

Tested x86_64-linux.

Attachment: patch-3.txt
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]