Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values

[Tim Shen <timshen at google dot com>]

On Sun, Sep 14, 2014 at 3:16 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Thus, are you going to send an actual patch? I'm wondering if we could
> arrange it in such a way not to break the binary compatibility in the
> release branch (thus fix the bug there too) perhaps by not removing any data
> members, simply leaving them unused?! In mainline I suppose we are going to
> stabilize the ABI for the 5.0 release, thus we can do that. While we are at
> it, check that the order of the final remaining data members is still
> optimal size-wise.

I've made a patch that changes basic_regex's member only, by making
basic_regex::_M_traits heap allocated.

I believe that I didn't get it, but I'm still a little bit confused,
since we haven't instantiated and exported any regex class (except
regex_error, I suppose) to the binary, right?

Anyway, the patch is bootstrapped and tested with debug flag. Can it
be modified slightly to keep the binary compatibility?

Thanks :)


-- 
Regards,
Tim Shen

Attachment: a.diff
Description: Text document