This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch 1/3] Use manual regex algorithm switching

From: Jonathan Wakely <jwakely at redhat dot com>
To: Tim Shen <timshen91 at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 26 Apr 2014 00:56:20 +0100
Subject: Re: [Patch 1/3] Use manual regex algorithm switching
Authentication-results: sourceware.org; auth=none
References: <CAPrifDm8MwcHY8XSnW_z6Z_hLVS+Lw4huqWEF3_eNT=fw3mkRg at mail dot gmail dot com> <20140425211417 dot GM928 at redhat dot com> <CAPrifD=y+bxDS+V0yiKbc-GvKC5+Vr1H7ofxuLHF=BOvtdXMGA at mail dot gmail dot com>

On 25/04/14 18:14 -0400, Tim Shen wrote:

On Fri, Apr 25, 2014 at 5:14 PM, Jonathan Wakely <jwakely@redhat.com> wrote:

I wonder if this would be simpler to read like this:

       if (!__re._M_automaton->_M_has_backref
#ifndef _GLIBCXX_REGEX_USE_THOMPSON_NFA
           && __policy == _RegexExecutorPolicy::_S_alternate
#endif
          )


I don't think this has equivalent logic. If
_GLIBCXX_REGEX_USE_THOMPSON_NFA is not defined, the _S_alternate
should also work, for testing purpose.


That's why I thought #ifndef would work, not #ifdef

Other parts is good. Sorry for those inconvenience :(


No problem, that's why we all review each other's code publicly :)

Follow-Ups:
- Re: [Patch 1/3] Use manual regex algorithm switching
  - From: Tim Shen

References:
- [Patch 1/3] Use manual regex algorithm switching
  - From: Tim Shen
- Re: [Patch 1/3] Use manual regex algorithm switching
  - From: Jonathan Wakely
- Re: [Patch 1/3] Use manual regex algorithm switching
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]