This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: debug container patch
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: FranÃois Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 18 Apr 2014 11:22:21 +0100
- Subject: Re: debug container patch
- Authentication-results: sourceware.org; auth=none
- References: <53503D01 dot 5000007 at gmail dot com>
On 17 April 2014 21:43, FranÃois Dumont wrote:
> Hi
>
> Here is a patch to globally enhance debug containers implementation.
>
> I have isolated all code of special functions in a base class so that in
> C++11 we can use default implementations for the debug containers. This way
> implementation is simpler and inherit from the noexcept qualifications.
Excellent.
> I had to put a _IsCpp11AllocatorAware template parameter to this new
> type for types that are not yet C++11 allocator aware. We will be able to
> simplify it later.
Minor: we switch from using "cpp" to "cxx", meaning "cpp" can
unambiguously refer to the preprocessor, so I would use _IsCxx11...
for that.
> I noticed also that in std/c++11/debug.cc we have some methods qualified
> with noexcept while in a C++03 user code those methods will have a throw()
> qualification. Is that fine ?
Yes, an empty throw() is compatible with noexcept(true).
I'll review the rest of the patch over the weekend, thanks!