This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: uclibc and libstdc++ and tmpnam
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: aldot at gcc dot gnu dot org, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 23 Jan 2014 19:36:10 +0000
- Subject: Re: uclibc and libstdc++ and tmpnam
- Authentication-results: sourceware.org; auth=none
- References: <ffb3d516-8f05-4429-8f6c-d3b38656c261 at BAMAIL02 dot ba dot imgtec dot org> <CAH6eHdT4mEA28kkTQJqYW2M1EYr+1GjTdEK7s+G8MQV_xxs7Gw at mail dot gmail dot com> <1390505539 dot 3022 dot 97 dot camel at ubuntu-sellcey>
On 23 January 2014 19:32, Steve Ellcey wrote:
>
> I tried pinging Bernhard about this patch but didn't hear back, would
> it be OK for me to check this in on his behalf? The only change I
> made to his patch was to use tmpnam(NULL) in GLIBCXX_CHECK_TMPNAM
> instead of tmpnam("NULL"). I think that makes more sense since tmpnam
> is going to try and write to the buffer that you pass it as an argument
> (if it is not null) and so passing a constant string does not make
> sense. I tested it with my mips-mti-linux-gnu target and made sure that
> tmpnam was found when using glibc and not found with uclibc and that
> both builds worked.
That sounds good, please go ahead and commit your updated patch.
Thanks for chasing it up.