This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] fix libstdc++/56267 - local iterator requirements

From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
To: FranÃois Dumont <frs dot dumont at gmail dot com>
Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 21 Jan 2014 19:39:15 +0000
Subject: Re: [patch] fix libstdc++/56267 - local iterator requirements
Authentication-results: sourceware.org; auth=none
References: <CAH6eHdQbHBYsG=ViDWMgNF5GH6=OwSUHCc4JBk8-Cis1y5AYxA at mail dot gmail dot com> <CAH6eHdR8PPUkeaQqT+2u3BBTH1zKkvXRBatJy5NEb9KqRgLEPg at mail dot gmail dot com> <52DD90E8 dot 8010607 at gmail dot com> <CAH6eHdQqDnCLoQWv5S=OAxXQzA=thL=aZQHvhkB_XemK8geHYQ at mail dot gmail dot com>

On 21 January 2014 10:00, Jonathan Wakely wrote:
> On 20 January 2014 21:11, FranÃois Dumont <frs.dumont@gmail.com> wrote:
>> On 01/20/2014 04:53 PM, Jonathan Wakely wrote:
>>
>> With this new design couldn't we change the conditions that are used to
>> decide when to cache the hash code. I haven't study it in detail but it
>> looks like the default constructible constraint could be removed, no ?
>
> Ah yes, I forgot about that part, I'll update the __cache_default
> definition. Thanks.

Like so. Tested x86_64-linux, committed to trunk.

2014-01-21  Jonathan Wakely  <jwakely@redhat.com>

        PR libstdc++/56267
        * include/bits/hashtable.h (__cache_default): Do not depend on
        whether the hash function is DefaultConstructible or CopyAssignable.
        (_Hashtable): Adjust static assertions.
        * doc/xml/manual/containers.xml (containers.unordered.cache): Update.
        * testsuite/23_containers/unordered_set/instantiation_neg.cc: Adjust
        dg-error line number.
        * testsuite/23_containers/unordered_set/
        not_default_constructible_hash_neg.cc: Remove.

Attachment: patch.txt
Description: Text document

References:
- [patch] fix libstdc++/56267 - local iterator requirements
  - From: Jonathan Wakely
- Re: [patch] fix libstdc++/56267 - local iterator requirements
  - From: Jonathan Wakely
- Re: [patch] fix libstdc++/56267 - local iterator requirements
  - From: François Dumont
- Re: [patch] fix libstdc++/56267 - local iterator requirements
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]