This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Regex bracket matcher cache optimization

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Tim Shen <timshen91 at gmail dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 07 Jan 2014 10:02:57 +0100
Subject: Re: [Patch] Regex bracket matcher cache optimization
Authentication-results: sourceware.org; auth=none
References: <CAPrifDnXTpH6K2A6O41OOx34AVMKKm=-gXPh7J0Sjq9=9rM8+g at mail dot gmail dot com> <CAPrifDkC0iSROtATApvp4_h9Je1S7XcahUBnOzK9g4ZdgYsBEg at mail dot gmail dot com>

Hi,

On 01/07/2014 07:48 AM, Tim Shen wrote:

I'd prefer to propose another patch that should be commited with this
one, which fix bugs (say _M_flags & regex_constants::icase, not "&&"),
and do more  "matcher optimization".

It is now more DRY (_RegexTranslator<>) and efficient, but <regex>
takes longer to compile, mainly because now we have 4 times more
_Compiler<> versions :)

Ideally, I would suggest committing first the improvements in yourprevious patch (by the way, thanks for the numbers!) + the pure bugfixes and separate the further performance improvements which havecompile-time performance implications (how big?), see if, eg, Jon hassomething to recommend. Can we do that?


Thanks,
Paolo.

Follow-Ups:
- Re: [Patch] Regex bracket matcher cache optimization
  - From: Tim Shen

References:
- [Patch] Regex bracket matcher cache optimization
  - From: Tim Shen
- Re: [Patch] Regex bracket matcher cache optimization
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]