This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [google][4.8] Add more inexpensive debug checks to vector, bitvector, deque

From: François Dumont <frs dot dumont at gmail dot com>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
Date: Mon, 06 Jan 2014 21:43:37 +0100
Subject: Re: [google][4.8] Add more inexpensive debug checks to vector, bitvector, deque
Authentication-results: sourceware.org; auth=none
References: <CALoOobOrbSCSUJh8qGZ-uLjrZ5ZwX2ctF4529Ff3vgw6E3CGVw at mail dot gmail dot com>

Hello

For my information, all those checks are already done in gcc_GLIBCXX_DEBUG mode, why duplicating those in normal mode with adedicated macro ? Is it that you only want to keep debug checks thathave a constant time cost ?

I am interested because I plan to do some enhancements to the debugmode and I could consider your needs in this context.


Thanks

FrançoisOn 01/06/2014 05:46 PM, Paul Pluzhnikov wrote:

Greetings,

For Google b/9127283, I've committed attached patch on google/gcc-4_8 branch.

Related: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56109

This caught ~10 bugs for us. erase(end()) and pop_back() on empty
vector appear to be most common.

Follow-Ups:
- Re: [google][4.8] Add more inexpensive debug checks to vector, bitvector, deque
  - From: Jonathan Wakely

References:
- [google][4.8] Add more inexpensive debug checks to vector, bitvector, deque
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]