This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3 patch] remove PR55043 kluge from unordered containers


On 11/14/2013 01:43 PM, Jonathan Wakely wrote:
Because the unordered containers now have noexcept move constructors
it is no longer necessary to ensure that is_copy_constructible depends
on the value_type, so remove that kluge.

2013-11-14  Jonathan Wakely<jwakely.gcc@gmail.com>

        * include/bits/alloc_traits.h (__allow_copy_cons): Remove.
        (__check_copy_constructible): Likewise.
        * include/bits/unordered_map.h (unordered_map, unordered_multimap):
        Do not derive from __check_copy_constructible.
        * include/bits/unordered_set.h (unordered_set, unordered_multiset):
        Likewise.
        * testsuite/23_containers/unordered_map/55043.cc: It is no longer
        necessary for is_copy_constructible to be correct to use nested
        unordered containers.
        * testsuite/23_containers/unordered_multimap/55043.cc: Likewise.
        * testsuite/23_containers/unordered_set/55043.cc: Likewise.
        * testsuite/23_containers/unordered_multiset/55043.cc: Likewise.


Tested x86_64-linux, committed to trunk.
Note that in unordered_set/55043.cc the ::equal functor is missing a '&' on its rhs parameter.

Do you want me to fix it ?

François


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]