This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Refactor regex executors

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Tim Shen <timshen91 at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 25 Oct 2013 16:27:47 +0200
Subject: Re: [Patch] Refactor regex executors
Authentication-results: sourceware.org; auth=none
References: <CAPrifDk=fh0tjQvFB=J_V3HktivWJ6icY0g6PNgYE_aHCAxugw at mail dot gmail dot com> <526A34C7 dot 7000708 at oracle dot com> <CAPrifDmMVjLSDBVBoafo02oC98B6wA_HQjK3JtdBNgzpR9v-Lg at mail dot gmail dot com> <526A7C53 dot 7060808 at oracle dot com> <CAPrifDn7tsKoAoYLSTizR-t==UQidaSzwsirwRnwFOFHzXTbXg at mail dot gmail dot com>

On 10/25/2013 04:22 PM, Tim Shen wrote:

On Fri, Oct 25, 2013 at 10:12 AM, Paolo Carlini
<paolo.carlini@oracle.com> wrote:

Ah good. Can't you just have split_bfs.cc defining the
_GLIBCXX_REGEX_DFS_QUANTIFIERS_LIMIT macro and including the existing
split.cc?

Here :) Hack the __FILE__ macro to let it report correctly.

Uhm, cute, didn't consider the naming issue, but I'm not sure we want todo that... What about having the code in a split.h and including it fromsplit.cc and split_bfs.cc instead?


Paolo.

Follow-Ups:
- Re: [Patch] Refactor regex executors
  - From: Tim Shen

References:
- [Patch] Refactor regex executors
  - From: Tim Shen
- Re: [Patch] Refactor regex executors
  - From: Paolo Carlini
- Re: [Patch] Refactor regex executors
  - From: Tim Shen
- Re: [Patch] Refactor regex executors
  - From: Paolo Carlini
- Re: [Patch] Refactor regex executors
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]