This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Internal functions for testsuite in regex

From: Tim Shen <timshen91 at gmail dot com>
To: Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 5 Oct 2013 04:41:25 -0400
Subject: Re: [Patch] Internal functions for testsuite in regex
Authentication-results: sourceware.org; auth=none
References: <CAPrifDmLY-=nJa8dNcsduTgWN2fT1PJ7bu9JEDqYdQCcyqC2JA at mail dot gmail dot com> <524EE6F2 dot 3080906 at oracle dot com> <524EE971 dot 6020904 at oracle dot com> <524EED43 dot 804 at oracle dot com> <CAPrifDmnwuOtHo==VPTwg5v37WN2UhDPCnd6TWM4tEB6qHhz-g at mail dot gmail dot com> <524FC2E7 dot 7070709 at oracle dot com>

On Sat, Oct 5, 2013 at 3:42 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> unrelated to the patch,
> I noticed for the first time that you have quite a few unsigned int and int,
> which always make me nervous, because the standards guarantee only 16 bits
> for those, thus unless you are sure that in practice only a few bits will be
> used, please consider using long and unsigned long instead.

Some are changed to size_t, some to long; some harmless ones are left.

I'll do a bootstrap & full test before committing.


-- 
Tim Shen

Attachment: a.patch
Description: Binary data

Follow-Ups:
- Re: [Patch] Internal functions for testsuite in regex
  - From: Paolo Carlini

References:
- [Patch] Internal functions for testsuite in regex
  - From: Tim Shen
- Re: [Patch] Internal functions for testsuite in regex
  - From: Paolo Carlini
- Re: [Patch] Internal functions for testsuite in regex
  - From: Paolo Carlini
- Re: [Patch] Internal functions for testsuite in regex
  - From: Paolo Carlini
- Re: [Patch] Internal functions for testsuite in regex
  - From: Tim Shen
- Re: [Patch] Internal functions for testsuite in regex
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]