This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Support assertions and greedy/ungreedy matching in regex
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 12 Sep 2013 18:00:33 +0200
- Subject: Re: [Patch] Support assertions and greedy/ungreedy matching in regex
- Authentication-results: sourceware.org; auth=none
- References: <CAPrifD=FsT0c6+VK7P6mFO6D9pVUbDdy8Soq-rmHoMA55t7t9A at mail dot gmail dot com> <5231DFC1 dot 7040108 at oracle dot com> <CAPrifD=c3VtHUjy00_1MzQWBT6_7K7F2PWCMDSRJtd2iUNCRvg at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Sep 12, 2013 at 11:51:57AM -0400, Tim Shen wrote:
> On Thu, Sep 12, 2013 at 11:37 AM, Paolo Carlini
> <paolo.carlini@oracle.com> wrote:
> > .. please fix the overlong lines, I spotted quite a few.
>
> Quite a few? I see only one line by casting:
> egrep '^\+.{80}' a.patch
>
> Even it's not 81.
That is not the right test, because you need to count all tabs (at least
the leading ones, you probably shouldn't have other tabs) as 8 columns
rather than just one. And there are 11 lines that are over the 80
columns limit then.
Jakub