This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch 1/2] Rewrite regex scanner
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: "Stephen M. Webb" <stephen dot webb at bregmasoft dot ca>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 23 Aug 2013 15:55:39 +0100
- Subject: Re: [Patch 1/2] Rewrite regex scanner
- References: <CAPrifDmbxT045MDCR04EHh21uhyC3QsmO+-_tF0bAkWst2pRwg at mail dot gmail dot com> <CAH6eHdQh74P2t81Ke5DwQDiDMPHpLB=X0B+2ipdEi+PEcOyzrA at mail dot gmail dot com> <CAPrifDmNS6rgw9HU8cLd-aPhBxLxhgB1eaaYaapsaLFcuf5b8A at mail dot gmail dot com> <52177557 dot 7060800 at bregmasoft dot ca>
On 23 August 2013 15:44, Stephen M. Webb wrote:
> On 08/23/2013 10:04 AM, Tim Shen wrote:
>>
>> By the way, it seems to take surprisingly short time to review; after
>> all, it's a huge patch.
>
> I'm still compiling...
I didn't compile it myself, I assume Tim has already done that before
submitting it for review! I just eyeballed it.
A lot of the changed lines are due to moving the code from on file to
another, and I didn't review the regex logic carefully, just
sanity-checked it. I'd usually be more stringent, but given that the
existing <regex> is so barebones if the tests pass after this patch
then it's better than what we had before, so I'm happy for it to go
in.