This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] [python libstdc++ printers] Fix gdb/15195
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gcc-patches at sourceware dot org, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 20 Aug 2013 20:44:43 +0100
- Subject: Re: [patch] [python libstdc++ printers] Fix gdb/15195
- References: <514ADF9B dot 1090407 at redhat dot com> <87mwtw4yy6 dot fsf at fleche dot redhat dot com> <51B6E3C5 dot 3000209 at redhat dot com> <87sj0mglyg dot fsf at fleche dot redhat dot com> <51D3D3C6 dot 2030001 at redhat dot com> <51ED030C dot 8000605 at redhat dot com> <87d2q91hjh dot fsf at fleche dot redhat dot com> <520DF73E dot 2090203__11644 dot 8208028034$1376647004$gmane$org at redhat dot com> <877gflmz8s dot fsf at fleche dot redhat dot com> <CAH6eHdQrMvLKPg8o2X5DqpFzxN4YHU1_C0KLh0wFp5sYhD375A at mail dot gmail dot com>
On 19/08/13 09:00, Jonathan Wakely wrote:
> On 16 August 2013 16:28, Tom Tromey wrote:
>>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>>
>> Phil> Anyway, I have regenerated the patch with the fixes requested.
>>
>> Thanks.
>>
>> Phil> 2013-08-16 Phil Muldoon <pmuldoon@redhat.com>
>>
>> Phil> PR gcc/53477
>>
>> I think this should say PR libstdc++/53477
>>
>> Other than this nit, it looks good to me.
>> I can't remember if I can approve these, but I think not.
>
> I can though, so it's approved with the ChangeLog nit fixed.
Committed with ChangeLog fix:
2013-08-20 Phil Muldoon <pmuldoon@redhat.com>
PR libstdc++/53477
http://sourceware.org/bugzilla/show_bug.cgi?id=15195
* python/libstdcxx/v6/printers.py (Printer.__call__): If a value
is a reference, fetch referenced value.
(RxPrinter.invoke): Ditto.
* testsuite/libstdc++-prettyprinters/cxx11.cc (main): Add -O0
flag. Add referenced value tests.
Patch was as posted.
Cheers,
Phil