This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] Make vector::at() assertion message more useful
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>, habets at google dot com
- Date: Sat, 17 Aug 2013 14:36:13 -0700
- Subject: Re: [patch] Make vector::at() assertion message more useful
- References: <ye6qk3jlqioo dot fsf at elbrus2 dot mtv dot corp dot google dot com> <920436ac-4138-4f62-81b3-1499ebf1211e at email dot android dot com> <CAAiZkiBUTYV-q+Vu07nxUQZ+JFnsgb7K+jg7Gmn_DH5HKr7aWQ at mail dot gmail dot com>
On 8/17/13 8:10 AM, Gabriel Dos Reis wrote:
I agree that we can't embark a significant IO library as part of a purely
data structure components.
...
This would be a regression, not an improvement.
A possible alternative is to make this conditional on e.g.
__GLIBCXX_VERBOSE_ASSERT (or some such) macro.
Then people who don't care about the extra I/O library (e.g. because
they are already paying that price), but do care about meaningful error
messages from the field, could turn it on.
If that's still untenable for trunk, I'll proceed with a local patch on
google/ branches instead.
Thanks,