This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Regex back-reference support

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Tim Shen <timshen91 at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 10 Aug 2013 18:04:57 +0200
Subject: Re: [Patch] Regex back-reference support
References: <CAPrifD=AyZ7GuSgDr0q0nbKFZ3aYWXUL3ZQcytYKLNfUeDq3dg at mail dot gmail dot com> <5206009E dot 60604 at oracle dot com> <CAPrifDmxg-ah3fn982Q4-6XHwCHi+7oiordMHw-DWC4aT6bQGg at mail dot gmail dot com> <52002c60-4ff4-4b33-b2a3-bcadb13b12e8 at email dot android dot com> <CAPrifDnK5Gq9MBhV0R1EG8tWGNFEOoyg-WyX65njgegg7uoH3Q at mail dot gmail dot com>

Hi,

On 08/10/2013 12:50 PM, Tim Shen wrote:

On Sat, Aug 10, 2013 at 5:41 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:

More important: we are adding support for a non trivial feature and not a single comment in the new code refers to it. This is not ok, please add at least 2 or 3.

Here it is. Two pieces of code concerning implementation logic is
commented. Add another testcase.

I'll test it again before final commit.

Thanks. Please also move out of line, to the *.tcc, _M_insert_backref,it's too big to be inline.

Also, in the new comment, you refer to a "stack", but in the same patchyou removed a std::stack and added a std::vector as data member,something seems inconsistent.


Thanks,
Paolo.

Follow-Ups:
- Re: [Patch] Regex back-reference support
  - From: Paolo Carlini

References:
- [Patch] Regex back-reference support
  - From: Tim Shen
- Re: [Patch] Regex back-reference support
  - From: Paolo Carlini
- Re: [Patch] Regex back-reference support
  - From: Tim Shen
- Re: [Patch] Regex back-reference support
  - From: Paolo Carlini
- Re: [Patch] Regex back-reference support
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]