This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix generic std::atomic<T>::compare_exchange_{weak,strong}

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Nathan Froyd <froydnj at mozilla dot com>
Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Sat, 27 Jul 2013 02:45:16 +0200
Subject: Re: [PATCH] fix generic std::atomic<T>::compare_exchange_{weak,strong}
References: <20130726173426 dot GA11900 at cerebro> <3c498ca8-12e6-48ec-9e2b-bb2abc6e3851 at email dot android dot com> <1044586962 dot 21254 dot 1374864154989 dot JavaMail dot zimbra at mozilla dot com> <51F2CF54 dot 2070700 at oracle dot com> <1685044565 dot 37661 dot 1374880031518 dot JavaMail dot zimbra at mozilla dot com>

Hi,

On 07/27/2013 01:07 AM, Nathan Froyd wrote:

----- Original Message -----

On 07/26/2013 08:42 PM, Nathan Froyd wrote:

Sure, I can do that.  For maximum effectiveness, it'd be good to have it
check the specializations for atomic<>, too.  Is there something in the
libstdc++ testsuite for iterating template instantiations over a list of
types, or do I have to roll the list myself?

testsuite/29_atomics already uses testsuite_common_types.h

New patch, this time with tests.  Let me know if test placement, etc. need
adjusting.

Patch looks great, Ok to commit. Minor nits: in the testcase we wantonly 2013 as Copyright year and let's standardize on -std=gnu++11.


Thanks,
Paolo.

References:
- [PATCH] fix generic std::atomic<T>::compare_exchange_{weak,strong}
  - From: Nathan Froyd
- Re: [PATCH] fix generic std::atomic<T>::compare_exchange_{weak,strong}
  - From: Paolo Carlini
- Re: [PATCH] fix generic std::atomic<T>::compare_exchange_{weak,strong}
  - From: Nathan Froyd
- Re: [PATCH] fix generic std::atomic<T>::compare_exchange_{weak,strong}
  - From: Paolo Carlini
- Re: [PATCH] fix generic std::atomic<T>::compare_exchange_{weak,strong}
  - From: Nathan Froyd

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]