This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Coverity complains "Big parameter passed by value" in /usr/include/c++/4.6/bits/stl_heap.h

From: Marc Glisse <marc dot glisse at inria dot fr>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, Dan Kegel <dank at kegel dot com>
Date: Thu, 25 Jul 2013 10:32:05 +0200 (CEST)
Subject: Re: Coverity complains "Big parameter passed by value" in /usr/include/c++/4.6/bits/stl_heap.h
References: <CAPF-yOaBvKa5THPBsN0Rx2j9r32pdbDLHU8f+rt_Pfzdtq12vQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1307250815440 dot 14859 at stedding dot saclay dot inria dot fr> <CAH6eHdQAqTqw7NxP6fEfj1G798dQG0ciViOoD9vMUm_+Mh=-cQ at mail dot gmail dot com>
Reply-to: libstdc++ at gcc dot gnu dot org

On Thu, 25 Jul 2013, Jonathan Wakely wrote:

On 25 July 2013 07:16, Marc Glisse wrote:


Isn't it this PR?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51965


Yes, I suppose it is, although your suggestion in comment 5 (which I
prefer to the pass-by-reference change) would still trigger the same
check in Coverity, wouldn't it?

Possibly, yes. I don't know if it has any heuristic to inhibit the warningdepending on what the caller looks like.

Note that IIRC the pass by reference version is much easier for the secondoccurence (pop_heap) and feels quite natural.


--
Marc Glisse

Follow-Ups:
- Re: Coverity complains "Big parameter passed by value" in /usr/include/c++/4.6/bits/stl_heap.h
  - From: Paolo Carlini

References:
- Coverity complains "Big parameter passed by value" in /usr/include/c++/4.6/bits/stl_heap.h
  - From: Dan Kegel
- Re: Coverity complains "Big parameter passed by value" in /usr/include/c++/4.6/bits/stl_heap.h
  - From: Marc Glisse
- Re: Coverity complains "Big parameter passed by value" in /usr/include/c++/4.6/bits/stl_heap.h
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]