This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix PR target/54407

From: Jack Howarth <howarth at bromo dot med dot uc dot edu>
To: Mike Stump <mikestump at comcast dot net>
Cc: Dominique Dhumieres <dominiq at lps dot ens dot fr>, redi at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org, iain at codesourcery dot com
Date: Mon, 11 Mar 2013 10:57:25 -0400
Subject: Re: [PATCH] fix PR target/54407
References: <20121016130305.GA2664@bromo.med.uc.edu> <29C5327D-BF87-4EBF-AE2E-DEB14F52F73E@comcast.net> <20121016172837.BB67B3BABA@mailhost.lps.ens.fr> <42F213A2-6A4D-45E4-9244-A9D7897FEB32@comcast.net>

On Tue, Oct 16, 2012 at 12:26:39PM -0700, Mike Stump wrote:
> On Oct 16, 2012, at 10:28 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> >> I'm not a big fan of just hiding the bug; why not just xfail it of darwin10 and darwin[5-9]?
> > 
> > I am viewing xfail for bugs that have a chance to be fixed some day.
> > Since the bug is fixed for darwin11 and 12, I doubt that Apple will backport it.
> > I would prefer a dg-skip-if may be with a comment about the bug.
> 
> Not a huge fan of skip either, but, if you guys really want to, that's ok by me.  Please do include a comment and a pointer to the Apple bug report number if available else a pointer to the gcc PR number where we talk about why we are skipping it.  Something like: OS bug, see gcc PR/x.  Short, easy to understand and one can read the PR for details, if one is really, really bored.

Mike,
   As I mentioned back in Oct, there is no explicit radar for this bug. It just happened to be fixed in the
rewrites of the pthread suppport for darwin11 and later. Dominique would like to see this committed for
gcc 4.8. Can you do the commit? I have attached the patch with updated ChangeLog.
         Jack

Attachment: pr54407.diff
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]