This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] Filter out basever symbols on Solaris
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Wed, 06 Mar 2013 12:08:11 +0100
- Subject: Re: [v3] Filter out basever symbols on Solaris
- References: <ydd38wj2t4l.fsf@lokon.CeBiTec.Uni-Bielefeld.DE> <mvm621fuw30.fsf@hawking.suse.de> <yddfw0i83k5.fsf@lokon.CeBiTec.Uni-Bielefeld.DE>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> Andreas Schwab <schwab@suse.de> writes:
>
>> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>>
>>> diff --git a/libstdc++-v3/scripts/extract_symvers.in b/libstdc++-v3/scripts/extract_symvers.in
>>> --- a/libstdc++-v3/scripts/extract_symvers.in
>>> +++ b/libstdc++-v3/scripts/extract_symvers.in
>>> @@ -49,9 +49,12 @@ SunOS)
>>> if readelf --help | grep -- --wide > /dev/null; then
>>> readelf="$readelf --wide"
>>> fi
>>> + # Omit _DYNAMIC etc. for consistency with extract_symvers.pl, only
>>> + # present on Solaris.
>>> ${readelf} ${lib} |\
>>> sed -e 's/ \[<other>: [A-Fa-f0-9]*\] //' -e '/\.dynsym/,/^$/p;d' |\
>>> egrep -v ' (LOCAL|UND) ' |\
>>> + egrep -v '(_DYNAMIC|_GLOBAL_OFFSET_TABLE_|_PROCEDURE_LINKAGE_TABLE_|_edata|_end|_etext)$' |\
>>
>> Shouldn't the regexp also be anchored (with a space) at the beginning?
>
> This works indeed. I was a bit worried if a space was guaranteed at
> that position, rather than general whitespace. Consider the patch
> amended accordingly.
Any word on this patch? Is has remained unreviewed for a week.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University