This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Ed Smith-Rowland <3dw4rd at verizon dot net>
Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
Date: Thu, 07 Feb 2013 16:16:56 +0100
Subject: Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
References: <51131A02.7020104@verizon.net> <5113BDBA.6040500@oracle.com> <5113C444.3090104@verizon.net>

On 02/07/2013 04:12 PM, Ed Smith-Rowland wrote:

On 02/07/2013 09:44 AM, Paolo Carlini wrote:
.. in the testcase, I would rather have the full Copyright blurb, if only for consistency.

Paolo.

Done as obvious.

Thanks. There is another issues however: test01 should return void not int.

Also, please add "PR libstdc++/56193" to the ChangeLog of the fix itself (Bugzilla didn't pick the commit because was missing)

Thanks,
Paolo.

Follow-Ups:
- Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: Paolo Carlini

References:
- [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: Ed Smith-Rowland
- Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: Paolo Carlini
- Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: Ed Smith-Rowland

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]