This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libstdc++: Fix up explicit-hle.cc test


> Now in the form of a tested patch (regtested on x86_64-linux and
> i686-linux).  Ok for trunk?
> 
> dg-additional-options unfortunately isn't supported in libstdc++ testsuite,
> so had to use second dg-options, and also the \(, \) were wrong and resulted
> in no matches.

Looks good to me (but cannot approve). Thanks Jakub for fixing this up.

-Andi

> 
> 2013-01-22  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc:
> 	Tightten scan-assembler-times regexps, add dg-additional-options for
> 	ia32, add -g0 -fno-exceptions -fno-asynchronous-unwind-tables to
> 	dg-options.
> 
> --- libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc.jj	2013-01-21 10:57:10.199935240 +0100
> +++ libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc	2013-01-22 14:46:15.851668073 +0100
> @@ -1,9 +1,10 @@
> -// { dg-options "-std=gnu++0x" }
>  // { dg-do compile { target i?86-*-* x86_64-*-* } }
> -// { dg-final { scan-assembler-times "\(xacquire\|\.byte.*0xf2\)" 14 } }
> -// { dg-final { scan-assembler-times "\(xrelease\|\.byte.*0xf3\)" 14 } }
> +// { dg-options "-std=gnu++0x -g0 -fno-exceptions -fno-asynchronous-unwind-tables" }
> +// { dg-options "-std=gnu++0x -g0 -fno-exceptions -fno-asynchronous-unwind-tables -march=i486" { target ia32 } }
> +// { dg-final { scan-assembler-times "xacquire\|\.byte\[^\n\r]*0xf2" 14 } }
> +// { dg-final { scan-assembler-times "xrelease\|\.byte\[^\n\r]*0xf3" 14 } }
>  
> -// Copyright (C) 2008, 2009, 2013 Free Software Foundation, Inc.
> +// Copyright (C) 2008-2013 Free Software Foundation, Inc.
>  //
>  // This file is part of the GNU ISO C++ Library.  This library is free
>  // software; you can redistribute it and/or modify it under the
> 
> 
> 	Jakub
> 

-- 
ak@linux.intel.com -- Speaking for myself only.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]