This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix code regression

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: François Dumont <frs dot dumont at gmail dot com>
Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sun, 23 Sep 2012 12:27:18 +0200
Subject: Re: Fix code regression
References: <505EDF90.8080405@gmail.com>

Hi,

On 09/23/2012 12:08 PM, François Dumont wrote:

Hi

I detect this regression while running performance tests. I think it comes from:

2012-04-12 Benjamin Kosnik <bkoz@redhat.com>

    * include/bits/unordered_map.h (__unordered_map): Remove.
    (__unordered_multimap): Remove.
    Add aliases for __umap_traits, __umap_hashtable, __ummap_traits,
    __ummap_hashtable.
    (unordered_map): Derive from __umap_hashtable.
    (unordered_multimap): Derive from __ummap_hashtable.
    * include/bits/unordered_set.h (__unordered_set): Remove.
    (__unordered_multiset): Remove.
    ...

2012-09-19 François Dumont <fdumont@gcc.gnu.org>

    * testsuite/performance/23_containers/insert_erase/41975.cc: Use
    __uset_hashtable rather than now missing __unordered_set.

Ok to commit ?

Given the current code, I think it qualifies as obvious. Anyway, too bad anyway that we don't have anymore the __unordered_* names for the extension containers taking an additional parameter, seemed very natural.

By the way, Francois, I think it's time to commit the patch for 44436... and thanks again!

Thanks,
Paolo.

References:
- Fix code regression
  - From: François Dumont

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]