This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Add overflow checking to __cxa_vec_new[23]

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, libstdc++ <libstdc++ at gcc dot gnu dot org>
Date: Mon, 17 Sep 2012 12:15:31 +0200
Subject: Re: [C++ PATCH] Add overflow checking to __cxa_vec_new[23]
References: <503364F2.6020908@redhat.com> <5056F286.8000202@redhat.com>

Hi,

On 09/17/2012 11:51 AM, Florian Weimer wrote:

On 08/21/2012 12:37 PM, Florian Weimer wrote:
I don't think there are any callers out there, but let's fix this for
completeness.
A compiler emitting code to call this function would still have to
perform overflow checks for the new T[n][m] case, so this interface is
not as helpful as it looks at first glance.
Tested on x86_64-redhat-linux-gnu.
Ping?

This function is apparently used by compilers based on the EDG front-end, so it's not actually dead.

Being code that touches the library, the patch should go to the libstdc++ maliling list too. Likewise the testcase, should be in the libstdc++ testsuite, I guess.

That said, I didn't really follow the details of your recent work. Who did? Jason? I would gently ping the same maintainer.

Thanks!
Paolo.

Follow-Ups:
- Re: [C++ PATCH] Add overflow checking to __cxa_vec_new[23]
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]