This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] fix libstdc++/53263
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 10 May 2012 23:18:51 +0200
- Subject: Re: [v3] fix libstdc++/53263
- References: <4FAADB55.3080208@gmail.com>
Hi,
On 05/09/2012 11:02 PM, François Dumont wrote:
Here is a patch for PR 53263.
I have also generalize the idea of performing checks on unsafe
iterators for better performance to several other debug checks.
2012-05-09 François Dumont <fdumont@gcc.gnu.org>
PR libstdc++/53263
* include/debug/safe_iterator.h (__gnu_debug::__base): Move...
* include/debug/functions.h: ... Here. Add debug function
overloads to perform checks on normal iterators when possible.
* include/debug/macros.h (__glibcxx_check_heap,
__glibcxx_check_heap_pred): Use __gnu_debug::__base on iterator
range.
Tested under linux x86_64 debug mode.
Ok for trunk and 4.7 branch ?
Thanks. Considering that this isn't a regression and also that nobody
reported the issue for so many years, the patch seems a bit largish to
me to go into the branch. Thus, let's apply to mainline only and
consider the issue closed. If people insist, seriously insist ;) we may
reconsider for 4.7.2.
Thanks again!
Paolo.
PS: are you finally able to manage Bugzilla, yes?