This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[v3] RFC: rename __calculate_memory_order

From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
To: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Cc: Andrew MacLeod <amacleod at redhat dot com>, Aldy Hernandez <aldyh at redhat dot com>, Benjamin Kosnik <bkoz at redhat dot com>
Date: Sat, 3 Dec 2011 12:58:43 +0000
Subject: [v3] RFC: rename __calculate_memory_order

Are there any objections to this patch?

I find the function easier to parse in this form and it allows it to
be constexpr. Maybe more importantly, it determines the memory order
to be used by compare_exchange_xxx on failure so I think
__cmpexch_failure_order is a more descriptive name than
__calculate_memory_order.

        * include/bits/atomic_base.h (__calculate_memory_order): Rename to...
        (__cmpexch_failure_order): This, and rewrite as constexpr function.
        (compare_exchange_strong, compare_exchange_weak): Use it.
        * include/std/atomic (compare_exchange_strong, compare_exchange_weak):
        Likewise.

Tested x86_64-linux.

Attachment: cmpexch_failure_order.txt
Description: Text document

Follow-Ups:
- Re: [v3] RFC: rename __calculate_memory_order
  - From: Benjamin Kosnik

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]