This is the mail archive of the
mailing list for the libstdc++ project.
Re: hashtable exception safety patch
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: Paolo Carlini <pcarlini at gmail dot com>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 12 Sep 2011 21:17:27 +0200
- Subject: Re: hashtable exception safety patch
- References: <4E2F1A56.firstname.lastname@example.org> <4E2F204B.email@example.com> <4E31C6CE.firstname.lastname@example.org> <7B3982F6-FEAA-4023-AC36-84B10A513651@oracle.com> <4E3849E9.email@example.com> <4E5FD090.firstname.lastname@example.org> <4E67D2AA.email@example.com> <4E6DE38F.firstname.lastname@example.org> <4E6E589C.email@example.com>
On 09/12/2011 09:08 PM, François Dumont wrote:
HiAlmost. Before that, please just rebase on the patch I attached in my
previous message: I see you (re)introduced various problems, like '/' at
the end of lines, instead of the beginning; size_type
__saved_next_resize wrongly non-const in rehash(size_type); the comment:
Yes, ext/throw_allocator.h was just what I needed, with even
better type names. Here is the patch again with the same ChangeLog
entry. Tested under linux x86_64.
Ok to commit ?
// Allocate the new node before doing the rehash so that we don't
// do a rehash if the allocation throws.
again in the wrong place. There may be more, just rebase, please.