This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)
- From: Diego Novillo <dnovillo at google dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>, libstdc++ at gcc dot gnu dot org
- Cc: reply at codereview dot appspotmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Tue, 6 Sep 2011 13:46:32 -0400
- Subject: Re: [patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)
- References: <20110906162854.5C60B190B10@elbrus2.mtv.corp.google.com> <CAD_=9DQTK4-aZKNV6c68HK+zsHNFQtKTrcztEEb1oMF-TvEdBg@mail.gmail.com> <CALoOobNLK-x0BsQ5qcJQUXA_iOkh7E3rynSyJt96wTLyvQNqhg@mail.gmail.com>
On Tue, Sep 6, 2011 at 12:54, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Tue, Sep 6, 2011 at 9:44 AM, Diego Novillo <dnovillo@google.com> wrote:
>
>> OK. ÂAny reason not to send this (or a variant) to mainline?
>
> AFAIU, mainline is not interested -- there is already a debug mode (enabled
> by _GLIBCXX_DEBUG), which catches many of the same bugs (and more), and
> introduction of "parallel" debug modes is undesirable.
>
> Unfortunately, _GLIBCXX_DEBUG makes no performance guarantees (making some
> normally constant-time operations O(N), etc.) and so we can't just turn
> it on in Google.
Right. That's why I thought of a variant. Maybe we want to have
levels of checking, or a _GLBICXX_DEBUG_FAST. But this is something
to discuss with libstdc++ (CC'd).
Diego.
>
> Thanks,
> --
> Paul Pluzhnikov
>