This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] Fix two C++ errors in libstdc++. (issue4341041)
- From: Jeffrey Yasskin <jyasskin at google dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: reply at codereview dot appspotmail dot com, gcc-patches at gcc dot gnu dot org, Jason Merrill <jason at redhat dot com>, libstdc++ at gcc dot gnu dot org
- Date: Thu, 31 Mar 2011 14:25:09 -0700
- Subject: Re: [patch] Fix two C++ errors in libstdc++. (issue4341041)
- References: <20110331190036.DABFE1695C9@enki.mtv.corp.google.com> <4D94D8FE.30301@oracle.com> <4D94DAC7.8060005@oracle.com>
On Thu, Mar 31, 2011 at 12:49 PM, Paolo Carlini
<paolo.carlini@oracle.com> wrote:
> On 03/31/2011 09:41 PM, Paolo Carlini wrote:
>>>
>>> I think this is a candidate to backport to libstdc++-4.6.1.
>>>
>>> exception_ptr.h needs the forward declaration because it's
>>> included from<typeinfo> ?before<typeinfo> ?defines std::type_info.
>>
>> before going ahead with the patch - I'm not at all sure it's enough, for
>> <exception> itself for example
>
> I had a closer look to what we have and indeed the patch seems enough to
> solve the existing issues. Thanks. I think we want indeed to apply the
> patchlet to mainline and 4_6-branch, but my basic puzzlement stays, indeed
> it's the real reason why the problem remained unnoticed for so much time!
Thanks. Is that an OK that I can commit this to mainline and 4_6-branch?
[For libstdc++@ people, the patch is at
http://codereview.appspot.com/4341041 and
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02261.html]