This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: RFC: add a testsuite for libstdc++ pretty-printers
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Benjamin Kosnik <bkoz at redhat dot com>, libstdc <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 14 Mar 2011 20:38:16 +0000
- Subject: Re: RFC: add a testsuite for libstdc++ pretty-printers
- References: <m3pqrj1hcw.fsf@fleche.redhat.com> <20110127092441.62efa77b@shotwell> <m37hdqnp9c.fsf@fleche.redhat.com> <m362rlbfx2.fsf@fleche.redhat.com>
On 14 March 2011 20:33, Tom Tromey wrote:
> Tom> * testsuite/libstdc++-pp/simple.cc: New file.
> Tom> * testsuite/lib/gdb-test.exp: New file.
> Tom> * testsuite/libstdc++-pp/pp.exp: New file.
>
> Benjamin> feel free to spell out prettyprinters instead of using pp, if you want
> Benjamin> to make it very obvious what is going on in this directory.
>
> Benjamin> we really strive for clarity given that this testsuite is so large
>
> Tom> No problem, I will do that.
>
> I updated my patch for this.
>
> These new tests require a very new gdb in order to fully pass. ?In
> particular these tests pointed out some buglets that are only fixed in
> CVS, not in any release.
>
>
> Trying to dynamically adjust the tests for the gdb version looks like a
> pain.
>
> Maybe I could change the tests to check the gdb version and xfail the
> tests for gdb < 7.3. ?Would that be ok?
That works for me, currently noone can test the printers, so if we get
to a point where people with a new enough gdb can test them that's a
huge improvement.
> Or I could leave it as-is, but I assume that nobody wants to see new
> FAILs.
Not really :-)