Re: [v3]libstdc++/13631

[François Dumont <francois dot cppdevs at free dot fr>]

On 12/17/2010 12:57 PM, Paolo Carlini wrote:
> Hi,
>    
> >      Thanks for the help, attached is what I come too.
> >      
> The general idea makes a lot of sense to me. To be clear: which specific
> problems is the patch fixing? Does it fix completely all the issues
> raised in 13631?
>    
I think so, it targets specifically the issue you will meat if you try 
to use 2 different catalogs at the same time. I will write a test case 
on that to make it obvious.
> >      I had to impact src/Makefile.am to force build in gnu++0x mode.
> >      
> I'm not sure to understand this: which specific C++0x features are you
> using in the new code? Should not be necessary to build the .cc file in
> C++0x mode... By the way, instead of including the whole<memory>,
> <ext/concurrence.h>  should be enough, no?
>    
I though mutex usage was a C++0x feature but you are right, once I 
directly use ext/concurrence.h I didn't need C++0x mode anymore.
> > The weird thing is that once I run autoreconf I got all Makefile.in
> > modified throughout the lib like that:
> >
> > --- doc/Makefile.in     (revision 167954)
> > +++ doc/Makefile.in     (working copy)
> > @@ -38,11 +38,7 @@
> >          $(srcdir)/Makefile.am
> >   subdir = doc
> >   ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
> > -am__aclocal_m4_deps = $(top_srcdir)/../libtool.m4 \
> > -       $(top_srcdir)/../ltoptions.m4 $(top_srcdir)/../ltsugar.m4 \
> > -       $(top_srcdir)/../ltversion.m4 $(top_srcdir)/../lt~obsolete.m4 \
> > -       $(top_srcdir)/crossconfig.m4 $(top_srcdir)/linkage.m4 \
> > -       $(top_srcdir)/../config/enable.m4 \
> > +am__aclocal_m4_deps = $(top_srcdir)/../config/enable.m4 \
> >          $(top_srcdir)/../config/futex.m4 \
> >          $(top_srcdir)/../config/iconv.m4 \
> >          $(top_srcdir)/../config/lead-dot.m4 \
> > @@ -55,7 +51,11 @@
> >          $(top_srcdir)/../config/override.m4 \
> >          $(top_srcdir)/../config/stdint.m4 \
> >          $(top_srcdir)/../config/unwind_ipinfo.m4 \
> > -       $(top_srcdir)/acinclude.m4 $(top_srcdir)/../config/gc++filt.m4 \
> > +       $(top_srcdir)/../libtool.m4 $(top_srcdir)/../ltoptions.m4 \
> > +       $(top_srcdir)/../ltsugar.m4 $(top_srcdir)/../ltversion.m4 \
> > +       $(top_srcdir)/../lt~obsolete.m4 $(top_srcdir)/crossconfig.m4 \
> > +       $(top_srcdir)/linkage.m4 $(top_srcdir)/acinclude.m4 \
> > +       $(top_srcdir)/../config/gc++filt.m4 \
> >          $(top_srcdir)/../config/tls.m4 $(top_srcdir)/configure.ac
> >   am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
> >          $(ACLOCAL_M4)
> >
> > Any idear where it might come from ? I am still using autoreconf 2.64.
> >      
> Apparently somebody forgot to regenerate the SVN copy of those files. I
> did that moments ago. Please let me know if you are still seeing
> something unusual.
>    
Thanks, everything is back to normal now.