This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: templace abuses


On 12/03/2010 12:22 PM, Jonathan Wakely wrote:

Hmm, the operators in testsuite_template_abuse.h aren't meant to be for iterators though, are they? If I understand the problem, it's that greedy operators intended for other types interfere and get applied to iterators - so calling them iterators_ops is misleading.

How about<testsuite_greedy_ops.h> ?

Also, namespace N and struct X in that header could be named better -
short names are ok in a .cc test but a header included from many files
has more chance of name collisions.  I would suggest maybe namespace
ops, greedy or greedy_ops.  If the namespace changes then I think X is
probably OK.

Thanks for fixing this problem, François.

Jonathan
Yes, I like greedy ops. Here is the new proposition.

If so I will apply it as soon as I have been able to test it. I am working on an other issue and can't build anymore for the moment.

François

Attachment: ChangeLog.entry
Description: Text document

Attachment: greedy_ops.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]