Re: [patch libstdc++]: PR/43738 - basic_file_stdio.cc uses ioctl on a fd, but not available on mingw32

[Kai Tietz <ktietz70 at googlemail dot com>]

2010/12/2 Paolo Carlini <paolo.carlini@oracle.com>:
> On 12/02/2010 12:32 PM, Kai Tietz wrote:
>> Hello,
>>
>> This patch fixes the described issue (as discussed in the bug-report).
>>
>> ChangeLog
>>
>> ? ? ? ? PR libstdc++/43738
>> ? ? ? ? * config/io/basic_file_stdio.cc (showmanyc): Special case for
>> mingw targets.
>>
>> Tested for i686-w64-mingw32, x86_64-w64-mingw32, and regression tested for
>> i686-pc-cygwin. Ok for apply?
>>
> Please always CC libstdc++ too when submitting patches for the C++ runtime.
>
> I would suggest instead defining a macro in
> config/os/mingw32/os_defines.h, a _GLIBCXX_NO_IOCTL or something and
> checking that is not defined in showmanyc before checking FIONREAD etc.
> And add a comment in that os_defines.h about the issue, maybe somebody
> will want to work on something better for mingw32 and/or just add an
> autoconf test for ioctl and clean up a bit of this mess.
>
> Paolo.
>
>
>

Paolo,

Fine by me. Here is the updated version.

ChangeLog

        * config/io/basic_file_stdio.cc (showmanyc): Check _GLIBCXX_NO_IOCTL
        before use of ioctl.
        * config/os/mingw32/os_defines.h (_GLIBCXX_NO_IOCTL): New.

Retested. Ok for apply?
Kai

Attachment: pr43738.txt
Description: Text document