This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Quoting fixes in GLIBCXX_ENABLE


Hello,

* Andreas Schwab wrote on Thu, Sep 30, 2010 at 11:42:50AM CEST:
> 	* acinclude.m4 (GLIBCXX_ENABLE): Properly quote argument to
> 	AC_HELP_STRING.  Double quote expansion of _g_help.
> 	(GLIBCXX_ENABLE_LIBSTDCXX_TIME): Double quote third argument of
> 	GLIBCXX_ENABLE.
> 	(GLIBCXX_ENABLE_CHEADERS): Likewise.
> 	(GLIBCXX_ENABLE_CLOCALE): Likewise.
> 	(GLIBCXX_ENABLE_ALLOCATOR): Likewise.
> 	(GLIBCXX_ENABLE_CSTDIO): Likewise.
> 	(GLIBCXX_ENABLE_SYMVERS): Likewise.
> 	* configure: Regenerate.

I can't approve this, and the patch looks right, but ...

> --- libstdc++/acinclude.m4	(revision 164746)
> +++ libstdc++/acinclude.m4	(working copy)

> @@ -1710,7 +1710,7 @@
>  dnl Default is generic.
>  dnl
>  AC_DEFUN([GLIBCXX_ENABLE_CLOCALE], [
> -  GLIBCXX_ENABLE(clocale,auto,[@<:@=MODEL@:>@],
> +  GLIBCXX_ENABLE(clocale,auto,[[[=MODEL]]],

... why move away from quadrigraphs?  They are the most robust spelling
wrt. quoting.  Ah, ok, Autoconf 2.64 m4_text_wrap still treated them as
four not one characters, so alignment is wrong; but this has been fixed
in newer Autoconf.  FWIW, I intend to propose moving GCC to 2.68 for
4.6.

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]