This is the mail archive of the
mailing list for the libstdc++ project.
Re: Quoting fixes in GLIBCXX_ENABLE
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: Andreas Schwab <schwab at redhat dot com>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 30 Sep 2010 21:50:51 +0200
- Subject: Re: Quoting fixes in GLIBCXX_ENABLE
- References: <firstname.lastname@example.org>
* Andreas Schwab wrote on Thu, Sep 30, 2010 at 11:42:50AM CEST:
> * acinclude.m4 (GLIBCXX_ENABLE): Properly quote argument to
> AC_HELP_STRING. Double quote expansion of _g_help.
> (GLIBCXX_ENABLE_LIBSTDCXX_TIME): Double quote third argument of
> (GLIBCXX_ENABLE_CHEADERS): Likewise.
> (GLIBCXX_ENABLE_CLOCALE): Likewise.
> (GLIBCXX_ENABLE_ALLOCATOR): Likewise.
> (GLIBCXX_ENABLE_CSTDIO): Likewise.
> (GLIBCXX_ENABLE_SYMVERS): Likewise.
> * configure: Regenerate.
I can't approve this, and the patch looks right, but ...
> --- libstdc++/acinclude.m4 (revision 164746)
> +++ libstdc++/acinclude.m4 (working copy)
> @@ -1710,7 +1710,7 @@
> dnl Default is generic.
> AC_DEFUN([GLIBCXX_ENABLE_CLOCALE], [
> - GLIBCXX_ENABLE(clocale,auto,[@<:@=MODEL@:>@],
> + GLIBCXX_ENABLE(clocale,auto,[[[=MODEL]]],
... why move away from quadrigraphs? They are the most robust spelling
wrt. quoting. Ah, ok, Autoconf 2.64 m4_text_wrap still treated them as
four not one characters, so alignment is wrong; but this has been fixed
in newer Autoconf. FWIW, I intend to propose moving GCC to 2.68 for