This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] basic_filebuf: 45628 + non-modal I/O


Hi,

> - The change doesn't eliminate them both; _M_writing is replaced
> with _M_post_overflow, which is true if "the last virtual function
> called was overflow."
> 
> - Besides simplification/cleanup, the point is to free space within
> the ABI constraint. _M_reading can be reused to cache the value of
> __check_facet(_M_codecvt).always_noconv(), a virtual call which
> seems to happen too frequently in the current impl.

Ok, that seems good. Thinking more about these issues, I believe we should indeed also change at the same time anything not part of the standard interface of this class to private instead of protected, just to make clear that we don't provide any stability guarantee for names beginning by single and double underscore, thus just implementation details (it's the general rule)

> 
Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]