This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] debug mode
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: François Dumont <francois dot cppdevs at free dot fr>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Wed, 18 Aug 2010 15:54:50 +0200
- Subject: Re: [patch] debug mode
- References: <4C4F3C54.8020106@free.fr> <4C50900B.6030705@oracle.com> <4C53E2FD.5070206@free.fr> <4C545CB5.4090902@oracle.com> <4C545E6D.5050409@oracle.com> <4C6BD03E.1050706@free.fr> <4C6BDBFB.6000307@oracle.com>
... one final comment ;)
On 08/18/2010 03:11 PM, Paolo Carlini wrote:
> Also, I see various testcases defining explicitly _GLIBCXX_DEBUG:
> normally we don't do that: check-debug takes care of testing the
> debug-mode behavior, uniformly. Please see if you can remove those
> explicit defines in the testcases.
>
About this: maybe you can remove the explicit -D_GLIBCXX_DEBUG and then
check in the testcase whether_GLIBCXX_DEBUG is defined or not: if it's
defined just run the normal test, otherwise call by hand
__builtin_abort(). In this way you are sure the test will consistently
xfail at runtime in all cases.
Paolo.
PS: don't diff the Changelog additions, when submitting patches. Instead
attach separately the new Changelog lines. See my patches, for examples.