This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] Use AC_COMPUTE_INT for EOF, SEEK_CUR, etc.
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 27 Jul 2010 20:54:06 +0200
- Subject: Re: [v3] Use AC_COMPUTE_INT for EOF, SEEK_CUR, etc.
- References: <4C4EB72D.4040907@oracle.com>
On 07/27/2010 12:38 PM, Paolo Carlini wrote:
Hi,
fixed the hack we had in place to avoid including<stdio.h>
unnecessarily thanks to Ralf help.
Tested x86_64-linux, committed to mainline.
Just a nit:
+ AC_MSG_CHECKING([For some <stdio.h> integer constants.])
...
+ AC_MSG_RESULT($glibcxx_cv_stdio_seek_end)
This will show as
checking For some <stdio.h> integer constants. -1
1
2
Please change it so that it looks like either:
checking for some <stdio.h> integer constants... done
or better
checking for the value of EOF... -1
checking for the value of SEEK_CUR... 1
checking for the value of SEEK_END... 2
You can do this with AC_CACHE_CHECK, or simply by adding new
AC_MSG_CHECKING invocations.
Paolo